From 056b3c268f199773018cd4fa738a3f51edfd7464 Mon Sep 17 00:00:00 2001
From: CharlesMcquade <6466275+CharlesMcquade@users.noreply.github.com>
Date: Mon, 14 Sep 2026 19:35:25 -0500
Subject: [PATCH] fix(notifications): keep dismissal helpers self-contained

---
 static/messages.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/static/messages.js b/static/messages.js
index 43105da1..8f956580 100644
--- a/static/messages.js
+++ b/static/messages.js
@@ -7445,7 +7445,9 @@ function _isApprovalDismissed(sid, approvalId) {
   if (!key) return false;
   const dismissed = _getDismissedApprovals();
   if (dismissed.includes(key)) return true;
-  const legacyKey = _legacyApprovalDismissKey(sid, approvalId);
+  const pending = typeof approvalId === "object" ? approvalId : {approval_id: approvalId};
+  const legacyId = pending && pending.approval_id;
+  const legacyKey = sid && legacyId ? String(sid) + "\0" + String(legacyId) : "";
   if (!legacyKey || !dismissed.includes(legacyKey)) return false;
   // Bind an old session/ID tombstone to the currently observed full owner.
   // This keeps an unresolved dismissal quiet through upgrade without letting