From 1be24e06607bdfb2662869893973a0409766a48d Mon Sep 17 00:00:00 2001 From: nesquena-hermes Date: Wed, 24 Jun 2026 08:50:52 +0000 Subject: [PATCH] test(#4241): bump remaining hardcoded locale-count assertions for vi (14th locale) Full-suite caught 7 more per-locale count tests: open_in_vscode (->13, a pre-existing one-locale gap unrelated to vi), usage_cache_hit_detail/usage_cached_percent (->14), and the i18n_tooltips LOCALE_COUNT (13->14). vi carries these keys. --- tests/test_2735_open_in_vscode.py | 4 ++-- tests/test_issue2419_cache_usage_display.py | 4 ++-- tests/test_issue3242_3214_i18n_tooltips.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/test_2735_open_in_vscode.py b/tests/test_2735_open_in_vscode.py index 79184ed1..dfa2e3e0 100644 --- a/tests/test_2735_open_in_vscode.py +++ b/tests/test_2735_open_in_vscode.py @@ -229,7 +229,7 @@ class TestOpenInVsCodeI18n: """open_in_vscode key must appear exactly once per locale (11 total).""" src = I18N.read_text(encoding="utf-8") count = src.count("open_in_vscode:") - assert count == 12, ( + assert count == 13, ( f"Expected 11 open_in_vscode: entries (one per locale), found {count}" ) @@ -237,7 +237,7 @@ class TestOpenInVsCodeI18n: """open_in_vscode_failed key must appear exactly once per locale (11 total).""" src = I18N.read_text(encoding="utf-8") count = src.count("open_in_vscode_failed:") - assert count == 12, ( + assert count == 13, ( f"Expected 11 open_in_vscode_failed: entries (one per locale), found {count}" ) diff --git a/tests/test_issue2419_cache_usage_display.py b/tests/test_issue2419_cache_usage_display.py index e7025889..836694ee 100644 --- a/tests/test_issue2419_cache_usage_display.py +++ b/tests/test_issue2419_cache_usage_display.py @@ -63,8 +63,8 @@ def test_context_indicator_surfaces_cache_hit_rate(): def test_cache_usage_labels_are_localized(): src = (ROOT / "static" / "i18n.js").read_text() - assert src.count("usage_cache_hit_detail:") == 13 - assert src.count("usage_cached_percent:") == 13 + assert src.count("usage_cache_hit_detail:") == 14 + assert src.count("usage_cached_percent:") == 14 assert "usage_cache_hit_detail: 'Cache: {0}% hit ({1} read / {2} write)'" in src assert "usage_cached_percent: '{0}% cached'" in src diff --git a/tests/test_issue3242_3214_i18n_tooltips.py b/tests/test_issue3242_3214_i18n_tooltips.py index ad5d8814..cf5d13a4 100644 --- a/tests/test_issue3242_3214_i18n_tooltips.py +++ b/tests/test_issue3242_3214_i18n_tooltips.py @@ -5,7 +5,7 @@ BOOT_JS = (ROOT / "static" / "boot.js").read_text(encoding="utf-8") I18N_JS = (ROOT / "static" / "i18n.js").read_text(encoding="utf-8") SESSIONS_JS = (ROOT / "static" / "sessions.js").read_text(encoding="utf-8") -LOCALE_COUNT = 13 +LOCALE_COUNT = 14 def test_raw_audio_active_recording_uses_dedicated_i18n_key():