From 26702fd19ff9b374915cffc5f1617837190d6a98 Mon Sep 17 00:00:00 2001 From: webtecnica Date: Tue, 22 Sep 2026 22:49:23 -0300 Subject: [PATCH] Remove flaky source-text oracle test (issue #7726) test_delete_cli_session_still_opens_writable_connection asserted on inspect.getsource(models.delete_cli_session) text, so it failed only in single-process full-suite runs when an earlier test leaves a monkeypatched/decorated wrapper bound on api.models. The writable-connection contract is already covered end to end by tests/test_issue1494_state_db_fd_leak.py::test_delete_cli_session_closes_connection, which performs a real delete and asserts the rows are gone. Remove the source oracle without a textual replacement; keep a short comment pointing at the behavioral coverage. --- tests/test_state_db_readonly_reads_models.py | 21 ++------------------ 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/tests/test_state_db_readonly_reads_models.py b/tests/test_state_db_readonly_reads_models.py index 735df0ed..c1d75294 100644 --- a/tests/test_state_db_readonly_reads_models.py +++ b/tests/test_state_db_readonly_reads_models.py @@ -253,22 +253,5 @@ def test_read_only_handle_rejects_writes(tmp_path): raise AssertionError("read-only handle unexpectedly allowed a write") except sqlite3.OperationalError: pass - - -def test_delete_cli_session_still_opens_writable_connection(): - """The lone write path (a DELETE) must keep a writable connection — a - read-only downgrade would make the delete silently no-op.""" - import inspect - - src = "\n".join( - ( - inspect.getsource(models.delete_cli_session), - inspect.getsource(models._delete_cli_session_locked), - ) - ) - assert "sqlite3.connect(str(db_path))" in src, ( - "delete_cli_session must keep its writable connection" - ) - assert "open_state_db_readonly" not in src, ( - "delete_cli_session must not be downgraded to the read-only helper" - ) +# The delete path's writable-connection contract is covered behaviorally by +# tests/test_issue1494_state_db_fd_leak.py::test_delete_cli_session_closes_connection.