ci: run tests across 5 shards (up from 3) + fix 2 latent test-isolation leaks
Two cross-file isolation leaks that a finer shard partition exposes are fixed at root so every shard passes regardless of execution order: - test_auth_session_persistence.py: bind api.auth STATE_DIR/_SESSIONS_FILE/ _LOGIN_ATTEMPTS_FILE in setUp + restore in tearDown (was relying on a sibling reload test to rebind them). - test_request_diagnostics_cache.py: pin the session-list cache source stamp via an autouse fixture (matches test_session_sidebar_cache.py) so a leaked state.db WAL sidecar can't cause a spurious cache-miss. Verified all shards green under 3-, 4-, and 5-way partitions. CI infra + test harness only; no application behavior change.
This commit is contained in:
1 parent
f2ffeacc64
commit
72f7530c45
4 files changed
+56
-4
No files matched your search
@@ -1,7 +1,34 @@
|
||||
import pytest
|
||||
|
||||
import api.routes as routes
|
||||
from api.request_diagnostics import RequestDiagnostics
|
||||
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def _stable_session_list_cache_stamp(monkeypatch):
|
||||
"""Pin the session-list cache source stamp so these stage-emission unit
|
||||
tests are independent of leaked filesystem state.
|
||||
|
||||
``_get_cached_session_list_payload`` stores then re-reads the cache, and the
|
||||
cache's freshness check compares the source stamp captured at store time
|
||||
against the stamp recomputed at read time. That stamp folds in a content
|
||||
fingerprint of the active ``state.db``: computing it opens the DB in WAL
|
||||
mode, which creates a zero-byte ``-wal`` sidecar as a side effect. If an
|
||||
earlier test in the same pytest shard left a ``state.db`` in the shared test
|
||||
STATE_DIR, the FIRST stamp computation materialises the ``-wal`` file and the
|
||||
immediately-following one sees a different sidecar stat — so the stamps
|
||||
differ, the cache reports a (spurious) miss, the builder runs, and the
|
||||
cache-hit assertion fails. In isolation no ``state.db`` exists, the stamp is
|
||||
a stable all-zero tuple, and the test passes — masking the bug at the
|
||||
current 3-shard split. These are unit tests of diagnostic STAGE emission, not
|
||||
of stamp derivation, so we stabilise the stamp the same way
|
||||
test_session_sidebar_cache.py does. (Patches the binding the cache's
|
||||
resolved-stamp lookup actually reads; auto-restored by monkeypatch.)
|
||||
"""
|
||||
monkeypatch.setattr(routes, "_session_list_cache_source_stamp", lambda _key: ("stable",))
|
||||
|
||||
|
||||
|
||||
def test_request_diagnostics_maybe_start_still_covers_sessions_route():
|
||||
assert RequestDiagnostics.maybe_start("GET", "/api/sessions") is not None
|
||||
|
||||
|
||||
Reference in new issue
Block a user