From a94dacb679591d1d351fbb554e1aa657024e13dd Mon Sep 17 00:00:00 2001
From: nesquena-hermes <nesquena-hermes@users.noreply.github.com>
Date: Sat, 4 Jul 2026 06:48:35 +0000
Subject: [PATCH] release #5513: fix live-emission anchor + source-validate all
 run-journal anchors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Codex re-gate finding: line 83 cited api/routes.py:15703-15762 for live SSE id:
emission, but that range is replay/helper code — the actual _sse_with_id() call
sites are 15918 (live /api/chat/stream), 15811 (runner-observe), 15721/15734
(journal replay). Corrected the bullet with the real, distinct anchors.

Also extended the test (test_rfc_run_journal_anchors_land_on_real_source) to
validate each named-symbol anchor (_parse_run_journal_event_id/_after_seq,
_runner_event_id, _replay_run_journal) + the live-emission anchor against the
actual source token, so no stale line number can silently pass.

Co-authored-by: rodboev <rodboev@users.noreply.github.com>
---
 docs/rfcs/session-sse-contract-v1.md          |  5 ++-
 ...test_issue4812_session_sse_contract_rfc.py | 35 +++++++++++++++++++
 2 files changed, 39 insertions(+), 1 deletion(-)

diff --git a/docs/rfcs/session-sse-contract-v1.md b/docs/rfcs/session-sse-contract-v1.md
index 9f36662e..0c4aa5f1 100644
--- a/docs/rfcs/session-sse-contract-v1.md
+++ b/docs/rfcs/session-sse-contract-v1.md
@@ -80,7 +80,10 @@ if source layout moves later.
   below, §Reconnect).
 - `_runner_event_id()` at `api/routes.py:15765-15772` constructs the event `id`
   field as `stream_id:seq`.
-- Live event `id:` is emitted during replay/stream at `api/routes.py:15703-15762`.
+- SSE frames carry their `id:` via the `_sse_with_id()` helper, emitted on the
+  live `/api/chat/stream` path at `api/routes.py:15918`, on the runner-observe
+  path at `api/routes.py:15811`, and during journal replay at
+  `api/routes.py:15721` / `15734`.
 - `_replay_run_journal()` reads events by `(session_id, stream_id)` at
   `api/routes.py:15703-15735`.
 - `api/streaming.py:6265-6285` writes current live agent streams to
diff --git a/tests/test_issue4812_session_sse_contract_rfc.py b/tests/test_issue4812_session_sse_contract_rfc.py
index e70925ec..7e3e33f2 100644
--- a/tests/test_issue4812_session_sse_contract_rfc.py
+++ b/tests/test_issue4812_session_sse_contract_rfc.py
@@ -126,6 +126,41 @@ class TestEndpointDistinction:
             f"_handle_session_events_stream definition; got: {routes[handler_line - 1].strip()!r}"
         )
 
+    def test_rfc_run_journal_anchors_land_on_real_source(self):
+        """Every named-symbol / emission anchor the RFC cites in the run-journal
+        inventory must land on the actual source token (not just be in-bounds),
+        so a stale line number can't silently pass (#5513 gate finding 2)."""
+        import re
+        text = _rfc()
+        routes = (REPO / "api" / "routes.py").read_text(encoding="utf-8").splitlines()
+
+        def _first_anchor_after(label):
+            m = re.search(r"%s.*?api/routes\.py:(\d+)" % re.escape(label), text, re.DOTALL)
+            assert m, f"RFC must cite a routes.py anchor near {label!r}"
+            return int(m.group(1))
+
+        # (label in RFC prose, token that must appear on the cited line)
+        checks = [
+            ("_parse_run_journal_event_id()", "def _parse_run_journal_event_id"),
+            ("_parse_run_journal_after_seq()", "def _parse_run_journal_after_seq"),
+            ("_runner_event_id()", "def _runner_event_id"),
+            ("_replay_run_journal()", "def _replay_run_journal"),
+        ]
+        for label, token in checks:
+            line = _first_anchor_after(label)
+            assert 1 <= line <= len(routes), f"{label} anchor api/routes.py:{line} beyond EOF"
+            assert token in routes[line - 1], (
+                f"RFC's {label} anchor api/routes.py:{line} must contain {token!r}; "
+                f"got: {routes[line - 1].strip()!r}"
+            )
+
+        # The live-emission bullet must cite the real _sse_with_id call site.
+        emit_line = _first_anchor_after("live `/api/chat/stream` path at")
+        assert "_sse_with_id" in routes[emit_line - 1], (
+            f"RFC's live-emission anchor api/routes.py:{emit_line} must be an "
+            f"_sse_with_id() call; got: {routes[emit_line - 1].strip()!r}"
+        )
+
     def test_contracts_distinguishes_both_endpoints(self):
         text = _contracts()
         assert "/api/sessions/{session_id}/events" in text, (