[HELD — independent review pending] Release v0.51.294 — stage-3401 (live-to-final redesign #3401 + 4 deep-review fixes) (#3741)
* Harden interrupted recovery control filtering * Redesign live-to-final assistant replies * Fix live activity anchor test fixture * Fix CI lint issues for live reply tests * Strengthen live progress prompt contract * Recover PR #3401 refresh on origin/master * Repair live-to-final refresh regressions * Fix live worklog refresh regressions * Show live footer timer on initial stream start * Restore live stream shell after reload * Preserve per-frame live SSE replay cursors * Preserve reasoning as Worklog Thinking cards * Quiet Worklog Thinking card styling * Align Worklog Thinking card styling * Scope live Worklog Thinking cards by segment * Suppress exact duplicate settled Thinking * Close #3401 merge review test gaps * fix(#3401): resolve 4 deep-review regressions (inline-think, reconnect-dup, neon skin, busy-gate worklog) Deep review (Codex diff-vs-master + live-browser drive) of the live-to-final refactor surfaced 4 regressions vs master that the rewritten suite no longer guarded: 1. Inline <think>…</think>answer reasoning vanished — _assistantReasoningPayloadText used $-anchored regexes so a leading think block + visible answer extracted nothing and the Thinking card never rendered. Removed the 3 $ anchors to match the (non-anchored) display stripper. Live: inline-think thinking-only turn now renders. 2. (CORE) reconnect/reload duplicated the live reply — _rememberRunJournalCursor advanced a closure-local seq but never wrote INFLIGHT[activeSid].lastRunJournalSeq, so a reload replayed the journal from after_seq=0 over restored lastAssistantText. Now mirrors the cursor onto INFLIGHT + schedules a throttled persist. 3. Neon skin silently broke — PR deleted the :root[data-skin="neon"] CSS but left Neon in the picker. Restored the neon CSS block from master. 4. Settled tool-worklog rebuild gated purely on !S.busy — dropped every prior settled turn's worklog when renderMessages re-ran during an active stream (switch-back to an in-progress session). Restored master's !S.busy || (S.toolCalls && S.toolCalls.length). Live: busy re-render now preserves tool cards (4→4, was 4→0). Live-verified all 4 + confirmed #3709/#3592 invariants still hold (1 thinking card, none below footer; distinct siblings preserved). + tests/test_issue3401_deep_review_fixes.py (7). * test(#3401): realign 3 stale source-shape assertions to the deep-review fixes Fix commit changed two source literals that existing stage tests scanned for: - test_live_activity_timeline.py (x2): split anchor 'if(!S.busy){' → the restored 'if(!S.busy || (S.toolCalls&&S.toolCalls.length)){' guard (fix 4). - test_run_journal_frontend_static.py: 'after_seq=0' not in source — fix 2's comment contained that literal; rephrased the comment to 'the zero floor (after_seq of 0)'. Intent of all three assertions unchanged; only the matched string updated. No code behavior change. * docs(changelog): v0.51.294 — Release JJ (stage-3401, #3401 live-to-final redesign) --------- Co-authored-by: Frank Song <franksong2702@gmail.com> Co-authored-by: Nathan-Hermes <nesquena-hermes@users.noreply.github.com> Co-authored-by: nesquena-hermes <[email protected]>
This commit is contained in:
46 files changed
+6018
-1407
No files matched your search
@@ -317,8 +317,7 @@ class TestIssue1298ActivityGroupExpandPersistence:
|
||||
)
|
||||
|
||||
def test_finalize_thinking_card_respects_user_expand(self):
|
||||
"""finalizeThinkingCard() must NOT force-collapse the live activity
|
||||
group when the user has explicitly expanded it (#1298)."""
|
||||
"""finalizeThinkingCard() must not force-collapse the live Worklog."""
|
||||
src = (REPO_ROOT / "static" / "ui.js").read_text()
|
||||
m = re.search(
|
||||
r"function finalizeThinkingCard\(\)\{(.*?)\n\}",
|
||||
@@ -326,16 +325,11 @@ class TestIssue1298ActivityGroupExpandPersistence:
|
||||
)
|
||||
assert m, "finalizeThinkingCard() must exist in ui.js"
|
||||
body = m.group(1)
|
||||
assert "_liveActivityUserExpanded" in body, (
|
||||
"finalizeThinkingCard() must respect the user's expand intent — "
|
||||
"without this guard, the panel snaps shut on every tool boundary"
|
||||
)
|
||||
# Hard fail if force-collapse is unconditional
|
||||
assert "_liveActivityUserExpanded !== true" in body or \
|
||||
"_liveActivityUserExpanded!==true" in body.replace(" ", ""), (
|
||||
"finalizeThinkingCard() must skip the force-collapse path when "
|
||||
"_liveActivityUserExpanded === true"
|
||||
assert "tool-call-group-collapsed" not in body, (
|
||||
"Live Worklog must remain expanded until the settled render replaces "
|
||||
"it with the final collapsed L1 Activity summary."
|
||||
)
|
||||
assert "aria-expanded','false'" not in body
|
||||
|
||||
def test_inline_onclick_records_user_intent(self):
|
||||
"""The summary button's click path must call _onLiveActivityToggle
|
||||
|
||||
Reference in new issue
Block a user