Core's 2026-09-09 catalog sync (hermes_cli/models_catalog_static.py, unreleased as of v2026.9.7) dropped ox-alpha-free — the Go relay delisted it (GET /zen/go/v1/models omits it, POST returns 401) — and added glm-5.3-flash and muse-spark-1.3-contributor. Mirror core main (29 ids, verified exact match). Keeping the delisted id would offer a model that always 401s — the original #5311 failure class. The installed-core equality test now skips while released cores still carry the delisted id (transition window documented in the test); verified 7/7 green with PYTHONPATH pointed at core main where equality binds.
303 lines
10 KiB
Python
303 lines
10 KiB
Python
"""#5311 follow-up: OpenCode Go uses the live Hermes CLI catalog again.
|
|
|
|
Background: #5611 made WebUI skip the live ``/v1/models`` probe for OpenCode Go
|
|
because the probe returned public-catalog models not enabled on the Go tier.
|
|
That premise no longer holds: Hermes core v0.20.5 (commit fcbd1076, tag
|
|
v2026.8.19) ships a Go-specific provider profile that probes
|
|
``https://opencode.ai/zen/go/v1/models`` directly and merges results
|
|
live-first with its curated Go list (hermes_cli/models.py, #49129). With the
|
|
correct Go-tier endpoint in core, WebUI should delegate like every other
|
|
provider (#1240): live catalog first, the curated static ``_PROVIDER_MODELS``
|
|
list as offline fallback only.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
import types
|
|
|
|
import api.config as config
|
|
import api.profiles as profiles
|
|
|
|
|
|
_PROVIDER_ENV_VARS = (
|
|
"OPENCODE_ZEN_API_KEY",
|
|
"OPENCODE_GO_API_KEY",
|
|
"OPENCODE_API_KEY",
|
|
)
|
|
|
|
|
|
def _scrub_provider_env(monkeypatch):
|
|
for name in _PROVIDER_ENV_VARS:
|
|
monkeypatch.delenv(name, raising=False)
|
|
|
|
|
|
def _install_fake_hermes_cli(
|
|
monkeypatch,
|
|
*,
|
|
provider_id: str,
|
|
live_ids,
|
|
core_version: str = "0.20.5",
|
|
raise_on_lookup: bool = False,
|
|
):
|
|
"""Install a hermes_cli stub that reports one authenticated provider."""
|
|
fake_pkg = types.ModuleType("hermes_cli")
|
|
fake_pkg.__path__ = []
|
|
fake_pkg.__version__ = core_version
|
|
|
|
fake_models = types.ModuleType("hermes_cli.models")
|
|
fake_models.list_available_providers = lambda: [
|
|
{"id": provider_id, "authenticated": True}
|
|
]
|
|
|
|
calls: list[str] = []
|
|
|
|
def provider_model_ids(pid):
|
|
calls.append(pid)
|
|
if raise_on_lookup:
|
|
raise RuntimeError("simulated provider_model_ids failure")
|
|
return list(live_ids) if pid == provider_id else []
|
|
|
|
fake_models.provider_model_ids = provider_model_ids
|
|
|
|
fake_auth = types.ModuleType("hermes_cli.auth")
|
|
|
|
def get_auth_status(pid):
|
|
if pid == provider_id:
|
|
return {"logged_in": True, "key_source": ""}
|
|
return {"logged_in": False, "key_source": ""}
|
|
|
|
fake_auth.get_auth_status = get_auth_status
|
|
|
|
monkeypatch.setitem(sys.modules, "hermes_cli", fake_pkg)
|
|
monkeypatch.setitem(sys.modules, "hermes_cli.models", fake_models)
|
|
monkeypatch.setitem(sys.modules, "hermes_cli.auth", fake_auth)
|
|
monkeypatch.delitem(sys.modules, "agent.credential_pool", raising=False)
|
|
monkeypatch.delitem(sys.modules, "agent", raising=False)
|
|
config.invalidate_models_cache()
|
|
return calls
|
|
|
|
|
|
def _configure(monkeypatch, tmp_path, *, provider: str, providers: dict | None = None):
|
|
hermes_home = tmp_path / "hermes-home"
|
|
hermes_home.mkdir()
|
|
monkeypatch.setattr(profiles, "get_active_hermes_home", lambda: hermes_home)
|
|
monkeypatch.setattr(config, "_get_config_path", lambda: tmp_path / "missing-config.yaml")
|
|
monkeypatch.setattr(config, "_models_cache_path", tmp_path / "models_cache.json")
|
|
monkeypatch.setattr(
|
|
config,
|
|
"cfg",
|
|
{
|
|
"model": {"provider": provider, "default": ""},
|
|
"providers": providers if providers is not None else {},
|
|
"fallback_providers": [],
|
|
},
|
|
)
|
|
monkeypatch.setattr(config, "_cfg_mtime", 0.0)
|
|
monkeypatch.setattr(config, "_cfg_path", config._get_config_path(), raising=False)
|
|
config.invalidate_models_cache()
|
|
|
|
|
|
def _provider_group(result: dict, provider_id: str) -> dict:
|
|
return next(g for g in result["groups"] if g.get("provider_id") == provider_id)
|
|
|
|
|
|
def _ids(group: dict) -> list[str]:
|
|
return [m.get("id") for m in group.get("models", [])]
|
|
|
|
|
|
def test_opencode_go_probes_live_catalog(monkeypatch, tmp_path):
|
|
"""The Go picker group must come from the live Hermes CLI catalog.
|
|
|
|
``sentinel-go-model`` is intentionally absent from every static list. If
|
|
WebUI special-cases OpenCode Go away from the live probe again (the #5611
|
|
stopgap), the sentinel disappears and this test fails.
|
|
"""
|
|
_scrub_provider_env(monkeypatch)
|
|
calls = _install_fake_hermes_cli(
|
|
monkeypatch,
|
|
provider_id="opencode-go",
|
|
live_ids=["sentinel-go-model", "kimi-k3"],
|
|
)
|
|
_configure(monkeypatch, tmp_path, provider="opencode-go")
|
|
|
|
result = config.get_available_models()
|
|
group = _provider_group(result, "opencode-go")
|
|
|
|
assert calls == ["opencode-go"]
|
|
ids = _ids(group)
|
|
assert "sentinel-go-model" in ids
|
|
assert "kimi-k3" in ids
|
|
assert all(m.get("label") for m in group["models"])
|
|
|
|
|
|
def test_opencode_go_old_core_ignores_nonempty_generic_catalog(monkeypatch, tmp_path):
|
|
"""Pre-v0.20.5 cores must not leak their generic public catalog into Go."""
|
|
_scrub_provider_env(monkeypatch)
|
|
calls = _install_fake_hermes_cli(
|
|
monkeypatch,
|
|
provider_id="opencode-go",
|
|
live_ids=["go-ineligible-old-core-sentinel"],
|
|
core_version="0.20.4",
|
|
)
|
|
_configure(monkeypatch, tmp_path, provider="opencode-go")
|
|
|
|
result = config.get_available_models()
|
|
group = _provider_group(result, "opencode-go")
|
|
|
|
assert calls == []
|
|
ids = _ids(group)
|
|
assert "go-ineligible-old-core-sentinel" not in ids
|
|
assert "kimi-k3" in ids
|
|
|
|
|
|
def test_opencode_go_static_fallback_when_probe_fails(monkeypatch, tmp_path):
|
|
"""Offline / CLI failure must fall back to the curated static list."""
|
|
_scrub_provider_env(monkeypatch)
|
|
calls = _install_fake_hermes_cli(
|
|
monkeypatch,
|
|
provider_id="opencode-go",
|
|
live_ids=[],
|
|
raise_on_lookup=True,
|
|
)
|
|
_configure(monkeypatch, tmp_path, provider="opencode-go")
|
|
|
|
result = config.get_available_models()
|
|
group = _provider_group(result, "opencode-go")
|
|
|
|
assert calls == ["opencode-go"]
|
|
ids = _ids(group)
|
|
assert "sentinel-go-model" not in ids
|
|
assert "glm-5" in ids
|
|
assert "kimi-k2.5" in ids
|
|
|
|
|
|
def test_opencode_go_config_allowlist_still_wins(monkeypatch, tmp_path):
|
|
"""An explicit ``providers.opencode-go.models`` allowlist remains the
|
|
local source of truth (#644) and is not bypassed by the live probe."""
|
|
_scrub_provider_env(monkeypatch)
|
|
calls = _install_fake_hermes_cli(
|
|
monkeypatch,
|
|
provider_id="opencode-go",
|
|
live_ids=["sentinel-go-model"],
|
|
)
|
|
_configure(
|
|
monkeypatch,
|
|
tmp_path,
|
|
provider="opencode-go",
|
|
providers={"opencode-go": {"models": ["glm-5"]}},
|
|
)
|
|
|
|
result = config.get_available_models()
|
|
group = _provider_group(result, "opencode-go")
|
|
|
|
assert calls == [] # probe never consulted
|
|
assert _ids(group) == ["glm-5"]
|
|
|
|
|
|
# ── Static fallback list contract ─────────────────────────────────────
|
|
# The remaining tests pin the offline fallback list itself to Hermes core's
|
|
# current curated contract (hermes_cli/models_catalog_static.py, core main
|
|
# 2026-09-10; the list originated in v0.20.5, commit fcbd1076). Core owns
|
|
# the sync duty against the live
|
|
# https://opencode.ai/zen/go/v1/models endpoint and
|
|
# https://opencode.ai/docs/go/, and WebUI only mirrors. This catches drift
|
|
# in either direction: ids core added and ids core dropped (e.g.
|
|
# ox-alpha-free, delisted from the Go relay on 2026-09-09).
|
|
|
|
import ast
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parent.parent
|
|
CONFIG_PATH = ROOT / "api" / "config.py"
|
|
CONFIG = CONFIG_PATH.read_text(encoding="utf-8")
|
|
|
|
EXPECTED_OPENCODE_GO_MODEL_IDS = [
|
|
"kimi-k3",
|
|
"kimi-k2.7-code",
|
|
"kimi-k2.6",
|
|
"kimi-k2.5",
|
|
"gpt-5.6-luna",
|
|
"grok-4.5",
|
|
"glm-5.3",
|
|
"glm-5.3-flash",
|
|
"glm-5.2",
|
|
"glm-5.1",
|
|
"glm-5",
|
|
"mimo-v2.5-pro",
|
|
"mimo-v2.5",
|
|
"mimo-v2-pro",
|
|
"mimo-v2-omni",
|
|
"minimax-m3",
|
|
"minimax-m2.7",
|
|
"minimax-m2.5",
|
|
"deepseek-v4-pro",
|
|
"deepseek-v4-flash",
|
|
"qwen3.8-max",
|
|
"qwen3.7-max",
|
|
"qwen3.7-plus",
|
|
"qwen3.6-plus",
|
|
"qwen3.5-plus",
|
|
"hy3",
|
|
"hy3-preview",
|
|
"muse-spark-1.2-contributor",
|
|
"muse-spark-1.3-contributor",
|
|
]
|
|
|
|
|
|
def _opencode_go_static_models():
|
|
tree = ast.parse(CONFIG, filename=str(CONFIG_PATH))
|
|
for node in tree.body:
|
|
if not isinstance(node, ast.Assign):
|
|
continue
|
|
if not any(isinstance(target, ast.Name) and target.id == "_PROVIDER_MODELS" for target in node.targets):
|
|
continue
|
|
provider_models = ast.literal_eval(node.value)
|
|
return provider_models["opencode-go"]
|
|
raise AssertionError("_PROVIDER_MODELS assignment not found")
|
|
|
|
|
|
def test_opencode_go_static_models_match_core_catalog_snapshot():
|
|
models = _opencode_go_static_models()
|
|
assert [model["id"] for model in models] == EXPECTED_OPENCODE_GO_MODEL_IDS
|
|
|
|
|
|
def test_opencode_go_static_models_match_installed_core_curated_list():
|
|
"""Exercise the actual Agent contract for the supported release pair.
|
|
|
|
The snapshot mirrors core main's curated catalog. A released (installed)
|
|
core can lag that sync by a few days — e.g. v2026.9.7 still lists
|
|
``ox-alpha-free``, which core removed on 2026-09-09 after the Go relay
|
|
delisted it. Equality binds only once the installed core carries the
|
|
mirrored sync; the marker for "lags the sync" is the delisted id still
|
|
being present. Anything else that differs is real drift and must fail.
|
|
"""
|
|
import pytest
|
|
|
|
hermes_cli = pytest.importorskip(
|
|
"hermes_cli", reason="hermes-agent is not a WebUI test dependency"
|
|
)
|
|
if not config._hermes_cli_supports_opencode_go_live_catalog():
|
|
pytest.skip(f"installed hermes-agent {hermes_cli.__version__} predates v0.20.5")
|
|
models_mod = pytest.importorskip("hermes_cli.models")
|
|
installed = list(models_mod._PROVIDER_MODELS["opencode-go"])
|
|
if "ox-alpha-free" in installed:
|
|
pytest.skip(
|
|
"installed hermes-agent catalog predates core's 2026-09-09 sync "
|
|
"(still lists relay-delisted 'ox-alpha-free'); equality binds "
|
|
"once a release carrying that sync is installed"
|
|
)
|
|
assert [model["id"] for model in _opencode_go_static_models()] == installed
|
|
|
|
|
|
def test_opencode_go_recent_additions_have_human_labels():
|
|
labels = {model["id"]: model["label"] for model in _opencode_go_static_models()}
|
|
assert labels["gpt-5.6-luna"] == "GPT 5.6 Luna"
|
|
assert labels["kimi-k3"] == "Kimi K3"
|
|
assert labels["glm-5.3"] == "GLM-5.3"
|
|
assert labels["grok-4.5"] == "Grok 4.5"
|
|
assert labels["qwen3.8-max"] == "Qwen3.8 Max"
|
|
assert labels["muse-spark-1.2-contributor"] == "Muse Spark 1.2 Contributor"
|
|
assert labels["muse-spark-1.3-contributor"] == "Muse Spark 1.3 Contributor"
|
|
assert labels["glm-5.3-flash"] == "GLM-5.3 Flash"
|