6ad84d7dd3
Route async-delegation completions by the immutable origin_ui_session_id (exact origin tab) and deliver them through a durable claim/complete/release lifecycle so they arrive exactly once, restart-safe, on both the background wakeup and next-turn drain paths. Combines #6185 (@carlotestor) + #6159 (@sysophelper-droid); supersedes #6002/#6225. Co-authored-by: carlotestor <carlotestor@users.noreply.github.com> Co-authored-by: sysophelper-droid <sysophelper-droid@users.noreply.github.com>
56 lines
2.7 KiB
Python
56 lines
2.7 KiB
Python
from pathlib import Path
|
|
|
|
|
|
def test_webui_drains_only_matching_background_completion_events():
|
|
src = Path("api/streaming.py").read_text(encoding="utf-8")
|
|
|
|
assert "def _drain_webui_process_notifications(" in src
|
|
assert "pending_async_acceptances: list | None = None" in src
|
|
assert "from tools.process_registry import process_registry" in src
|
|
assert "proc = process_registry.get(evt_sid)" in src
|
|
assert "def _completion_event_targets_webui_session(evt_session_key: str, session_id: str)" in src
|
|
assert "PROCESS_SESSION_INDEX.get(evt_session_key) == session_id" in src
|
|
assert "not _completion_event_targets_webui_session(evt_session_key, session_id)" in src
|
|
assert "skipped_events.append(evt)" in src
|
|
assert "completion_queue.put(evt)" in src
|
|
|
|
|
|
def test_webui_injects_process_notifications_without_persisting_them_as_user_text():
|
|
src = Path("api/streaming.py").read_text(encoding="utf-8")
|
|
|
|
assert "_process_notifications = _drain_webui_process_notifications(" in src
|
|
assert "pending_async_acceptances=_pending_async_acceptances" in src
|
|
assert "_accept_pending_async_delegations(" in src
|
|
assert "[*_process_notifications, msg_text]" in src
|
|
assert "_build_native_multimodal_message(workspace_ctx, _agent_msg_text" in src
|
|
assert "persist_user_message=msg_text" in src
|
|
|
|
|
|
def test_webui_sets_gateway_session_platform_for_background_watchers():
|
|
src = Path("api/streaming.py").read_text(encoding="utf-8")
|
|
|
|
assert "'HERMES_SESSION_PLATFORM': 'webui'" in src
|
|
assert "os.environ['HERMES_SESSION_PLATFORM'] = 'webui'" in src
|
|
assert "old_session_platform = os.environ.get('HERMES_SESSION_PLATFORM')" in src
|
|
assert "os.environ.pop('HERMES_SESSION_PLATFORM', None)" in src
|
|
|
|
|
|
def test_webui_age_gates_stale_background_completion_events():
|
|
"""Issue #4029: drain must drop completions older than the configured cap
|
|
so stale notifications can't be prepended to an unrelated later turn."""
|
|
src = Path("api/streaming.py").read_text(encoding="utf-8")
|
|
|
|
# The age-gate helper + its env override exist.
|
|
assert "def _stale_completion_max_age_seconds()" in src
|
|
assert "HERMES_WEBUI_STALE_COMPLETION_MAX_AGE_SECONDS" in src
|
|
# The drain reads completed_at and drops over-age events without requeueing.
|
|
assert "completed_at = evt.get('completed_at')" in src
|
|
assert "stale_age = time.time() - completed_at" in src
|
|
assert "is_stale = stale_age > stale_completion_max_age" in src
|
|
assert "if is_stale:" in src
|
|
# Over-age process events use the registry marker; async delegations finish
|
|
# their durable delivery claim. Neither path is added to skipped_events.
|
|
assert "_mark_process_completion_consumed(process_registry, evt_sid)" in src
|
|
assert "complete_async_delegation_delivery(evt, claim)" in src
|
|
|