8cc2d6f881
Two visible render PRs, gate-passed (deep-review round), Nathan-approved to ship. - #5757 (rodboev): mark active model with a Selected badge + open its provider group (#5748). Screenshot-verified (badge clear + correctly placed on active row). - #5758 (rodboev): suppress the live-token prose row that is a strict prefix of the final answer (#5749). Provenance-gated (live-prose:* token rows after last tool row only) so it can't eat legitimate narration; reproduction test proves the dupe is gone. Codex SAFE + full regression green (1576 render tests). 18 own tests pass together. Co-authored-by: t <a@b> Co-authored-by: rodboev <rodboev@users.noreply.github.com>
63 lines
2.8 KiB
Python
63 lines
2.8 KiB
Python
"""Regression coverage for #5748 model picker selected badge and scroll state."""
|
|
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
STYLE_CSS = (ROOT / "static" / "style.css").read_text(encoding="utf-8")
|
|
UI_JS = (ROOT / "static" / "ui.js").read_text(encoding="utf-8")
|
|
I18N_JS = (ROOT / "static" / "i18n.js").read_text(encoding="utf-8")
|
|
|
|
|
|
def _body_between(src: str, start: str, end: str) -> str:
|
|
start_idx = src.index(start)
|
|
end_idx = src.index(end, start_idx)
|
|
return src[start_idx:end_idx]
|
|
|
|
|
|
def test_model_dropdown_uses_viewport_height_cap():
|
|
assert "max-height:min(70vh,640px);overflow-y:auto;" in STYLE_CSS
|
|
|
|
|
|
def test_toggle_model_dropdown_scrolls_active_row_after_open():
|
|
body = _body_between(UI_JS, "async function toggleModelDropdown()", "function closeModelDropdown")
|
|
|
|
assert "_positionModelDropdown();" in body
|
|
assert "scrollIntoView({block:'nearest'})" in body
|
|
assert body.index("_positionModelDropdown();") < body.index("scrollIntoView({block:'nearest'})")
|
|
|
|
|
|
def test_model_picker_renders_selected_badge_without_replacing_configured_badge():
|
|
assert "const _selectedModelBadge=(m)=>" in UI_JS
|
|
assert "model-opt-badge--selected" in UI_JS
|
|
assert "t('model_badge_selected')||'Selected'" in UI_JS
|
|
assert "_getConfiguredModelBadge(modelId,badgeMap,providerId)" in UI_JS
|
|
|
|
|
|
def test_selected_badge_is_keyed_to_current_model_value():
|
|
assert "String((m&&m.value)||'')===String((_selectedModelState&&_selectedModelState.model)||(sel&&sel.value)||'')" in UI_JS
|
|
|
|
|
|
def test_selected_badge_is_keyed_to_current_model_provider():
|
|
assert "const _selectedModelState=(typeof _modelStateForSelect==='function')?_modelStateForSelect(sel,sel.value)" in UI_JS
|
|
assert "const _modelProviderForSelectedBadge=(m)=>" in UI_JS
|
|
assert "return (_provider&&_provider!=='default')?_provider:null;" in UI_JS
|
|
assert "String(_modelProviderForSelectedBadge(m)||'')===String((_selectedModelState&&_selectedModelState.model_provider)||'')" in UI_JS
|
|
assert "const _isSelectedModelRow=(m)=>" in UI_JS
|
|
assert "row.className='model-opt'+(_isSelectedModelRow(m)?' active':'');" in UI_JS
|
|
|
|
|
|
def test_selected_group_key_prefers_provider_matched_row_before_value_fallback():
|
|
assert "const _hit=_modelData.find(m=>m&&!m.endpointErrorOnly&&_isSelectedModelRow(m)) || _modelData.find(m=>m&&!m.endpointErrorOnly&&String(m.value||'')===_selVal);" in UI_JS
|
|
assert "_groupOpenState[groupKey]=(groupKey===_selectedGroupKey)" in UI_JS
|
|
|
|
|
|
def test_selected_badge_helper_does_not_accept_dead_select_parameter():
|
|
assert "_selectedModelBadge(m,sel)" not in UI_JS
|
|
assert "_selectedModelBadge(m)" in UI_JS
|
|
assert "_buildModelRow=(m,sel" not in UI_JS
|
|
assert "_makeModelRow(m,sel" not in UI_JS
|
|
|
|
|
|
def test_selected_badge_label_has_locale_entries():
|
|
assert I18N_JS.count("model_badge_selected:") >= 14
|