e775fb3355
* stage-3908: supported local pytest runner + symlink-guard on venv create/clear (Codex CORE fix) Rebased rodboev/franksong2702 #3908 onto v0.51.434. Adds scripts/test.sh dev runner + requirements-dev.txt + test_ci_hygiene.py + conftest version guard. Defensive fix on the authoritative gate: create_or_rebuild_venv refuses a symlinked .venv so 'python -m venv --clear' can't wipe the symlink target (same symlink-hardening class as #4217/#4234/#4240). Locked by a hygiene test. * Release OV: supported local pytest runner (#3908) scripts/test.sh + requirements-dev.txt + conftest version guard + hygiene tests. Self-rebased franksong2702's #3908 onto v0.51.434; full Codex+Opus+suite gate. Codex CORE fix applied: refuse to create/--clear a virtualenv through a symlinked .venv (symlink-hardening class, #4217/#4234/#4240), locked by a hygiene assertion. Co-authored-by: franksong2702 <franksong2702@users.noreply.github.com> --------- Co-authored-by: nesquena-hermes <agent@nesquena-hermes> Co-authored-by: franksong2702 <franksong2702@users.noreply.github.com>
64 lines
2.7 KiB
Python
64 lines
2.7 KiB
Python
"""Small hygiene regression checks for CI and frontend console noise."""
|
|
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def test_github_actions_quotes_pyyaml_version_specifier():
|
|
"""Unquoted `pyyaml>=6.0` is parsed by the shell as stdout redirection."""
|
|
workflow = ROOT / ".github" / "workflows" / "tests.yml"
|
|
text = workflow.read_text(encoding="utf-8")
|
|
|
|
assert '"pyyaml>=6.0"' in text or "'pyyaml>=6.0'" in text
|
|
assert "pip install pyyaml>=6.0" not in text
|
|
|
|
|
|
def test_pytest_integration_marker_is_registered():
|
|
config = ROOT / "pytest.ini"
|
|
text = config.read_text(encoding="utf-8")
|
|
|
|
assert "markers" in text
|
|
assert "integration:" in text
|
|
|
|
|
|
def test_local_test_runner_uses_supported_venv_before_pytest_collection():
|
|
runner = (ROOT / "scripts" / "test.sh").read_text(encoding="utf-8")
|
|
conftest = (ROOT / "tests" / "conftest.py").read_text(encoding="utf-8")
|
|
|
|
assert "python3.13 python3.12 python3.11 python3" in runner
|
|
assert "requirements-dev.txt" in runner
|
|
assert 'HERMES_WEBUI_TEST_PYTHON' in runner
|
|
assert '[[ -x "$candidate" ]] && printf' in runner
|
|
assert "exec \"$PYTHON_BIN\" -m pytest" in runner
|
|
# Destructive-fs guard: never create/clear a virtualenv through a symlinked .venv
|
|
# (`python -m venv --clear` would empty the symlink's target).
|
|
assert '-L "$VENV_DIR"' in runner
|
|
assert "Hermes WebUI tests require Python 3.11, 3.12, or 3.13" in conftest
|
|
assert "Run ./scripts/test.sh" in conftest
|
|
|
|
|
|
def test_local_test_runner_bootstrap_handles_broken_venvs_safely():
|
|
runner = (ROOT / "scripts" / "test.sh").read_text(encoding="utf-8")
|
|
select_body = runner.split("select_python() {", 1)[1].split("\n}\n\nPYTHON_BIN", 1)[0]
|
|
create_body = runner.split("create_or_rebuild_venv() {", 1)[1].split("\n}\n\nselect_python", 1)[0]
|
|
|
|
assert "has_pip()" in runner
|
|
assert 'if ! "$base_py" -m venv "${venv_args[@]}"; then' in create_body
|
|
assert 'rm -rf "$VENV_DIR"' in create_body
|
|
assert '[[ ! -x "$VENV_PY" ]]' in create_body
|
|
assert 'if ! has_pip "$VENV_PY"; then' in create_body
|
|
assert 'venv_guidance "$base_py"' in create_body
|
|
assert 'printf \'%s\\n\' "$requested_path"' not in select_body
|
|
assert 'base_py="$requested_path"' in select_body
|
|
assert 'desired_major_minor="$(python_major_minor "$base_py")"' in select_body
|
|
assert 'if has_pip "$VENV_PY"; then' in select_body
|
|
assert 'create_or_rebuild_venv "$base_py" rebuild' in select_body
|
|
|
|
|
|
def test_live_model_success_log_is_debug_not_default_console_log():
|
|
ui = (ROOT / "static" / "ui.js").read_text(encoding="utf-8")
|
|
|
|
assert "console.debug('[hermes] Live models loaded" in ui
|
|
assert "console.log('[hermes] Live models loaded" not in ui
|