370 lines
14 KiB
Python
370 lines
14 KiB
Python
"""Regression tests for #4961 URL query composer prefill behavior."""
|
|
import json
|
|
import re
|
|
import shutil
|
|
import subprocess
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = Path(__file__).parent.parent.resolve()
|
|
SESSIONS_JS_PATH = REPO_ROOT / "static" / "sessions.js"
|
|
BOOT_JS_PATH = REPO_ROOT / "static" / "boot.js"
|
|
REPRO_PATH = REPO_ROOT / "tests" / "fixtures" / "webui-PR-TARGET-5884-REPRO.md"
|
|
SESSIONS_JS = SESSIONS_JS_PATH.read_text(encoding="utf-8")
|
|
BOOT_JS = BOOT_JS_PATH.read_text(encoding="utf-8")
|
|
NODE = shutil.which("node")
|
|
|
|
pytestmark = pytest.mark.skipif(NODE is None, reason="node not on PATH")
|
|
|
|
|
|
def _run_node(source: str) -> str:
|
|
result = subprocess.run(
|
|
[NODE],
|
|
input=source,
|
|
cwd=str(REPO_ROOT),
|
|
capture_output=True,
|
|
encoding="utf-8",
|
|
text=True,
|
|
timeout=30,
|
|
)
|
|
if result.returncode != 0:
|
|
raise RuntimeError(result.stderr)
|
|
return result.stdout.strip()
|
|
|
|
|
|
def _recorded_repro_query() -> str:
|
|
repro = REPRO_PATH.read_text(encoding="utf-8")
|
|
match = re.search(r"\?q=hello\+world", repro)
|
|
assert match, "expected recorded query in repo fixture"
|
|
return match.group(0)
|
|
|
|
|
|
def _node_prelude() -> str:
|
|
return f"""
|
|
const sessionsSrc = {SESSIONS_JS!r};
|
|
const bootSrc = {BOOT_JS!r};
|
|
function extractFunc(src, name) {{
|
|
const re = new RegExp('(?:async\\\\s+)?function\\\\s+' + name + '\\\\s*\\\\(');
|
|
const start = src.search(re);
|
|
if (start < 0) throw new Error(name + ' not found');
|
|
let i = src.indexOf('{{', start);
|
|
let depth = 1; i++;
|
|
while (depth > 0 && i < src.length) {{
|
|
if (src[i] === '{{') depth++;
|
|
else if (src[i] === '}}') depth--;
|
|
i++;
|
|
}}
|
|
return src.slice(start, i);
|
|
}}
|
|
function evalSession(name) {{
|
|
globalThis[name] = (0, eval)('(' + extractFunc(sessionsSrc, name) + ')');
|
|
}}
|
|
function evalBoot(name) {{
|
|
globalThis[name] = (0, eval)('(' + extractFunc(bootSrc, name) + ')');
|
|
}}
|
|
"""
|
|
|
|
|
|
def test_prefill_intent_parses_q_prompt_and_send_flag():
|
|
source = _node_prelude() + """
|
|
global.window = { location: { search: '?prompt=backup&q=hello%20world&send=YES' } };
|
|
evalSession('_composerPrefillIntentFromLocation');
|
|
const first = _composerPrefillIntentFromLocation();
|
|
window.location.search = '?prompt=from+prompt';
|
|
const second = _composerPrefillIntentFromLocation();
|
|
window.location.search = '?q=%20%20&send=1';
|
|
const third = _composerPrefillIntentFromLocation();
|
|
console.log(JSON.stringify({ first, second, third }));
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload["first"] == {
|
|
"hasParams": True,
|
|
"hasText": True,
|
|
"text": "hello world",
|
|
"autoSend": False,
|
|
}
|
|
assert payload["second"] == {
|
|
"hasParams": True,
|
|
"hasText": True,
|
|
"text": "from prompt",
|
|
"autoSend": False,
|
|
}
|
|
assert payload["third"] == {
|
|
"hasParams": True,
|
|
"hasText": False,
|
|
"text": " ",
|
|
"autoSend": False,
|
|
}
|
|
|
|
|
|
def test_prefill_cleanup_removes_only_consumed_query_params():
|
|
source = _node_prelude() + """
|
|
function applyUrl(rel) {
|
|
const next = new URL(rel, 'https://example.test');
|
|
window.location.href = next.href;
|
|
window.location.pathname = next.pathname;
|
|
window.location.search = next.search;
|
|
window.location.hash = next.hash;
|
|
}
|
|
global.window = {
|
|
location: {},
|
|
history: {
|
|
state: { from: 'test' },
|
|
calls: [],
|
|
replaceState(state, title, url) {
|
|
this.calls.push({ state, title, url });
|
|
this.state = state;
|
|
applyUrl(url);
|
|
}
|
|
}
|
|
};
|
|
global.document = { baseURI: 'https://example.test/app/' };
|
|
applyUrl('/app/?q=hello&prompt=backup&send=1&session_id=target&keep=1#frag');
|
|
evalSession('_consumeComposerPrefillParamsFromLocation');
|
|
evalSession('_sessionUrlForSid');
|
|
_consumeComposerPrefillParamsFromLocation();
|
|
const cleaned = window.history.calls[0];
|
|
const promoted = _sessionUrlForSid('abc 123');
|
|
console.log(JSON.stringify({ cleaned, promoted }));
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload["cleaned"]["url"] == "/app/?session_id=target&keep=1#frag"
|
|
assert payload["cleaned"]["state"] == {"from": "test"}
|
|
assert payload["promoted"] == "/app/session/abc%20123?keep=1#frag"
|
|
|
|
|
|
def test_root_prefill_keeps_saved_local_sidebar_only():
|
|
source = _node_prelude() + """
|
|
evalBoot('_prefillHasDraftText');
|
|
evalBoot('_rootPrefillNeedsFreshComposer');
|
|
const result = {
|
|
savedLocalWins: _rootPrefillNeedsFreshComposer(null, 'saved-local', { hasText: true }),
|
|
explicitSessionWins: _rootPrefillNeedsFreshComposer('url-session', 'saved-local', { hasText: true }),
|
|
blankPrefillIgnored: _rootPrefillNeedsFreshComposer(null, 'saved-local', { hasText: false })
|
|
};
|
|
console.log(JSON.stringify(result));
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload == {
|
|
"savedLocalWins": True,
|
|
"explicitSessionWins": False,
|
|
"blankPrefillIgnored": False,
|
|
}
|
|
prefill_guard = BOOT_JS.find("if(_rootPrefillNeedsFreshComposer(urlSession, savedLocal, prefillIntent)){")
|
|
saved_state_pos = BOOT_JS.find("const savedSidebarOnlyState=(!urlSession&&savedLocal)")
|
|
saved_guard = BOOT_JS.find(
|
|
"if(savedSidebarOnlyState&&savedSidebarOnlyState.sidebarOnly){",
|
|
saved_state_pos,
|
|
)
|
|
load_pos = BOOT_JS.find("await loadSession(saved, {preserveActiveInput:true});")
|
|
assert prefill_guard >= 0
|
|
assert saved_state_pos >= 0
|
|
assert saved_guard > saved_state_pos
|
|
assert prefill_guard > saved_guard
|
|
assert load_pos > prefill_guard
|
|
|
|
|
|
def test_fresh_default_workspace_bind_skips_prefill_draft_boot():
|
|
source = _node_prelude() + """
|
|
(async () => {
|
|
evalBoot('_prefillHasDraftText');
|
|
evalBoot('_maybeBindFreshDefaultWorkspaceSession');
|
|
global.S = { session: null, _profileDefaultWorkspace: 'D:/workspace' };
|
|
global._workspacePanelMode = 'browse';
|
|
const calls = [];
|
|
global.newSession = async () => { calls.push('newSession'); };
|
|
const skipped = await _maybeBindFreshDefaultWorkspaceSession({ hasText: true });
|
|
const bound = await _maybeBindFreshDefaultWorkspaceSession({ hasText: false });
|
|
console.log(JSON.stringify({ skipped, bound, calls }));
|
|
})().catch(err => {
|
|
console.error(err);
|
|
process.exit(1);
|
|
});
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload == {
|
|
"skipped": False,
|
|
"bound": True,
|
|
"calls": ["newSession"],
|
|
}
|
|
|
|
|
|
def test_boot_query_prefill_focuses_composer_without_sending():
|
|
recorded_query = _recorded_repro_query()
|
|
source = (_node_prelude() + """
|
|
(async () => {
|
|
evalBoot('_applyComposerPrefillOnBoot');
|
|
const counts = { autoResize: 0, updateSendBtn: 0, focus: 0, send: 0 };
|
|
const msg = { value: '', focus() { counts.focus++; document.activeElement = this; } };
|
|
global.document = {
|
|
getElementById(id) {
|
|
return id === 'msg' ? msg : null;
|
|
}
|
|
};
|
|
global.$ = (id) => document.getElementById(id);
|
|
global.autoResize = () => { counts.autoResize++; };
|
|
global.updateSendBtn = () => { counts.updateSendBtn++; };
|
|
global.send = async () => { counts.send++; };
|
|
await _applyComposerPrefillOnBoot({ hasText: true, text: new URL('https://example.test/' + RECORDED_QUERY).searchParams.get('q'), autoSend: false });
|
|
console.log(JSON.stringify({ counts, value: msg.value, active: document.activeElement === msg }));
|
|
})().catch(err => {
|
|
console.error(err);
|
|
process.exit(1);
|
|
});
|
|
""").replace("RECORDED_QUERY", json.dumps(recorded_query))
|
|
payload = json.loads(_run_node(source))
|
|
assert payload["counts"] == {"autoResize": 1, "updateSendBtn": 0, "focus": 1, "send": 0}
|
|
assert payload["value"] == "hello world"
|
|
assert payload["active"] is True
|
|
|
|
|
|
def test_empty_or_absent_prefill_does_not_focus_composer():
|
|
source = _node_prelude() + """
|
|
(async () => {
|
|
evalBoot('_applyComposerPrefillOnBoot');
|
|
const counts = { focus: 0, send: 0 };
|
|
const msg = { value: 'unchanged', focus() { counts.focus++; } };
|
|
global.document = { getElementById(id) { return id === 'msg' ? msg : null; } };
|
|
global.$ = (id) => document.getElementById(id);
|
|
global.send = async () => { counts.send++; };
|
|
await _applyComposerPrefillOnBoot({ hasText: false, text: ' ' });
|
|
await _applyComposerPrefillOnBoot(null);
|
|
console.log(JSON.stringify({ counts, value: msg.value }));
|
|
})().catch(err => { console.error(err); process.exit(1); });
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload == {"counts": {"focus": 0, "send": 0}, "value": "unchanged"}
|
|
|
|
|
|
def test_non_empty_prefill_without_focus_method_still_updates_composer():
|
|
source = _node_prelude() + """
|
|
(async () => {
|
|
evalBoot('_applyComposerPrefillOnBoot');
|
|
const counts = { autoResize: 0, updateSendBtn: 0, send: 0 };
|
|
const msg = { value: '' };
|
|
global.document = {
|
|
activeElement: null,
|
|
getElementById(id) {
|
|
return id === 'msg' ? msg : null;
|
|
}
|
|
};
|
|
global.$ = (id) => document.getElementById(id);
|
|
global.autoResize = () => { counts.autoResize++; };
|
|
global.updateSendBtn = () => { counts.updateSendBtn++; };
|
|
global.send = async () => { counts.send++; };
|
|
await _applyComposerPrefillOnBoot({ hasText: true, text: 'hello world', autoSend: false });
|
|
console.log(JSON.stringify({ counts, value: msg.value, active: document.activeElement === msg }));
|
|
})().catch(err => { console.error(err); process.exit(1); });
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload == {
|
|
"counts": {"autoResize": 1, "updateSendBtn": 0, "send": 0},
|
|
"value": "hello world",
|
|
"active": False,
|
|
}
|
|
|
|
|
|
def test_terminal_prefill_step_consumes_params_after_boot_state_is_ready():
|
|
source = _node_prelude() + """
|
|
(async () => {
|
|
evalBoot('_applyComposerPrefillOnBoot');
|
|
evalBoot('_finalizeComposerPrefillOnBoot');
|
|
const counts = { autoResize: 0, updateSendBtn: 0, consume: 0, focus: 0, send: 0 };
|
|
const events = [];
|
|
const msg = { value: '', focus() { counts.focus++; events.push('focus'); document.activeElement = this; } };
|
|
global.document = {
|
|
getElementById(id) {
|
|
return id === 'msg' ? msg : null;
|
|
}
|
|
};
|
|
global.$ = (id) => document.getElementById(id);
|
|
global.autoResize = () => { counts.autoResize++; };
|
|
global.updateSendBtn = () => { counts.updateSendBtn++; };
|
|
global.send = async () => { counts.send++; };
|
|
global._consumeComposerPrefillParamsFromLocation = () => { counts.consume++; events.push('consume'); };
|
|
await _finalizeComposerPrefillOnBoot({ hasParams: true, hasText: true, text: 'hello world', autoSend: false });
|
|
delete global.autoResize;
|
|
await _finalizeComposerPrefillOnBoot({ hasParams: false, hasText: true, text: 'second pass', autoSend: false });
|
|
console.log(JSON.stringify({ counts, events, value: msg.value }));
|
|
})().catch(err => {
|
|
console.error(err);
|
|
process.exit(1);
|
|
});
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload["counts"] == {
|
|
"autoResize": 1,
|
|
"updateSendBtn": 1,
|
|
"consume": 1,
|
|
"focus": 2,
|
|
"send": 0,
|
|
}
|
|
assert payload["events"] == ["consume", "focus", "focus"]
|
|
assert payload["value"] == "second pass"
|
|
|
|
|
|
def test_explicit_session_url_keeps_target_session_with_prefill():
|
|
source = _node_prelude() + """
|
|
global.window = {
|
|
location: {
|
|
pathname: '/session/url-target',
|
|
search: '?q=hello%20world&send=1',
|
|
hash: ''
|
|
}
|
|
};
|
|
evalSession('_sessionIdFromLocation');
|
|
evalBoot('_prefillHasDraftText');
|
|
evalBoot('_rootPrefillNeedsFreshComposer');
|
|
console.log(JSON.stringify({
|
|
urlSession: _sessionIdFromLocation(),
|
|
bypassRootOverride: _rootPrefillNeedsFreshComposer(_sessionIdFromLocation(), 'saved-local', { hasText: true })
|
|
}));
|
|
"""
|
|
payload = json.loads(_run_node(source))
|
|
assert payload == {"urlSession": "url-target", "bypassRootOverride": False}
|
|
query_source = _node_prelude() + """
|
|
global.window = {
|
|
location: {
|
|
pathname: '/',
|
|
search: '?session_id=query-target&q=hello%20world&send=1',
|
|
hash: ''
|
|
}
|
|
};
|
|
evalSession('_sessionIdFromLocation');
|
|
evalBoot('_prefillHasDraftText');
|
|
evalBoot('_rootPrefillNeedsFreshComposer');
|
|
console.log(JSON.stringify({
|
|
urlSession: _sessionIdFromLocation(),
|
|
bypassRootOverride: _rootPrefillNeedsFreshComposer(_sessionIdFromLocation(), 'saved-local', { hasText: true })
|
|
}));
|
|
"""
|
|
query_payload = json.loads(_run_node(query_source))
|
|
assert query_payload == {"urlSession": "query-target", "bypassRootOverride": False}
|
|
prefill_pos = BOOT_JS.find(
|
|
"const prefillIntent=(typeof _composerPrefillIntentFromLocation==='function')?_composerPrefillIntentFromLocation():null;"
|
|
)
|
|
first_await_pos = BOOT_JS.find("const s=await api('/api/settings');", prefill_pos)
|
|
active_profile_pos = BOOT_JS.find(
|
|
"const activeProfileState = await _resolveActiveProfileBootstrapState();",
|
|
first_await_pos,
|
|
)
|
|
new_pos = BOOT_JS.find("await newSession(true);", active_profile_pos)
|
|
load_pos = BOOT_JS.find("await loadSession(saved, {preserveActiveInput:true});", active_profile_pos)
|
|
saved_pos = BOOT_JS.find("const saved=urlSession||savedLocal;")
|
|
check_pos = BOOT_JS.find("await checkInflightOnBoot(saved);", load_pos)
|
|
apply_pos = BOOT_JS.find("await _finalizeComposerPrefillOnBoot(prefillIntent);", check_pos)
|
|
assert saved_pos >= 0
|
|
assert prefill_pos >= 0
|
|
assert active_profile_pos > first_await_pos
|
|
assert "_consumeComposerPrefillParamsFromLocation();" not in BOOT_JS[prefill_pos:first_await_pos]
|
|
assert 0 <= active_profile_pos < new_pos
|
|
assert 0 <= active_profile_pos < load_pos
|
|
assert 0 <= check_pos < apply_pos
|
|
assert BOOT_JS.find("await _maybeBindFreshDefaultWorkspaceSession(prefillIntent);", prefill_pos) > prefill_pos
|
|
zero_message_pos = BOOT_JS.find(
|
|
"await renderSessionList();await _finalizeComposerPrefillOnBoot(prefillIntent);if(typeof startGatewaySSE==='function')startGatewaySSE();",
|
|
load_pos,
|
|
)
|
|
assert zero_message_pos > load_pos
|