* fix(reasoning): stop date-stamped Claude 3.0 ids from reading reasoning-capable _candidate_supports_reasoning captured a trailing date stamp as the minor version so bare date-stamped Claude 3.0 ids like claude-3-opus-20240229 satisfied the major==3 and minor>=7 gate and wrongly surfaced reasoning-effort controls. Cap the minor group to 1-2 digits with a (?!\d) guard so the date stamp is not read as a minor version -- the same date-stamp defense _is_pre_adaptive_anthropic already uses. Claude 3.0/3.5 now correctly report no reasoning support; 3.7+ and 4.x (incl. date-stamped builds) are unaffected. * test(reasoning): cover date-stamped Claude 3.0 not reasoning-capable Locks the heuristic so claude-3-opus-20240229 (and sibling date-stamped 3.0 ids) report no reasoning support while 3.7+/4.x stay capable. * fix(session): classify ACP adapter sessions into the CLI sidebar family Gateway ACP adapter sessions (source='acp' in state.db — Zed, external device bridges like a Rabbit R1) normalised to session_source 'other', which fell through BOTH sidebar buckets: sidebar_source=webui skips the state.db projection entirely (and ACP rows have no WebUI sidecar), while sidebar_source=cli keeps only CLI-classified rows. Result: ACP conversations were invisible and could never be clicked/imported. Classify 'acp' as a CLI-family source, mirroring 'tui' (a local interactive agent client): normalize_agent_session_source maps it to session_source 'cli' with label 'ACP', is_cli_session_row recognises the raw source, is_cli_session_row_visible keeps ended/untitled ACP rows visible (they are always user-driven), and frontend _isCliSession accepts raw === 'acp'. Zero-message ACP connect/reconnect stubs stay hidden via the existing message-count guard. Claim policy is untouched: ACP stays claimable like CLI/TUI per the documented 'future local agent sources' allowance in _is_claimable_cli_source. Rollback: revert this commit (pre-change file copies also in ~/.hermes/backups/acp-sidebar-fix-20260711/), then restart WebUI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(session): require a user turn before surfacing ACP rows An ended ACP connection can record only assistant/tool/system messages (replayed or aborted turn), which the blanket TUI-style visibility exception would surface despite not being user-driven. Gate the ACP branch on _count_user_turns(row) > 0, per Greptile review on #5939. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Release exp-v0.52.40: ACP sessions in sidebar (#5939) + date-stamped Claude 3.0 reasoning-control fix (#5934) --------- Co-authored-by: 黄云龙 <76432572+nankingjing@users.noreply.github.com> Co-authored-by: ai-ag2026 <261867348+ai-ag2026@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: nesquena-hermes <agent@nesquena-hermes>
451 lines
17 KiB
Python
451 lines
17 KiB
Python
"""Tests for model-aware reasoning effort chip visibility."""
|
|
|
|
from api import config as cfg
|
|
|
|
|
|
def test_cursor_acp_models_do_not_support_reasoning_effort_levels():
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
"cursor/composer-2.5",
|
|
provider_id="cursor-acp",
|
|
) == []
|
|
|
|
|
|
def test_openai_codex_gpt5_supports_reasoning_effort_levels():
|
|
efforts = cfg.resolve_model_reasoning_efforts(
|
|
"gpt-5.5",
|
|
provider_id="openai-codex",
|
|
)
|
|
assert "medium" in efforts
|
|
assert "high" in efforts
|
|
assert "xhigh" in efforts
|
|
assert "max" not in efforts
|
|
|
|
|
|
def test_openai_codex_prefixed_gpt5_supports_reasoning_effort_levels():
|
|
efforts = cfg.resolve_model_reasoning_efforts(
|
|
"@openai-codex:gpt-5.5",
|
|
provider_id="openai-codex",
|
|
)
|
|
assert "medium" in efforts
|
|
assert "high" in efforts
|
|
assert "xhigh" in efforts
|
|
assert "max" not in efforts
|
|
|
|
|
|
def test_openai_codex_max_effort_is_clamped_before_streaming():
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max",
|
|
"gpt-5.5",
|
|
provider_id="openai-codex",
|
|
) == "xhigh"
|
|
|
|
|
|
def test_unsupported_xhigh_degrades_to_high_not_disabled():
|
|
# o1/o3/o4 on openai-codex cap at low/medium/high. A configured xhigh (or
|
|
# max) must clamp DOWN to the highest supported level (high), not silently
|
|
# disable reasoning by returning "".
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"xhigh",
|
|
"o3-mini",
|
|
provider_id="openai-codex",
|
|
) == "high"
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max",
|
|
"o3-mini",
|
|
provider_id="openai-codex",
|
|
) == "high"
|
|
|
|
|
|
def test_coerce_never_escalates_above_configured_effort():
|
|
# A supported lower effort is returned verbatim; coercion only degrades.
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"low",
|
|
"gpt-5.5",
|
|
provider_id="openai-codex",
|
|
) == "low"
|
|
|
|
|
|
def test_coerce_preserves_effort_for_unrecognized_model():
|
|
# #3505 review: resolve_model_reasoning_efforts() returns [] for BOTH
|
|
# known-unsupported AND simply-unrecognized models (custom providers,
|
|
# aggregator-rewritten ids, brand-new releases). Coercion must NOT silently
|
|
# drop a configured effort just because we don't recognize the model — that
|
|
# would be a behavior change vs sending it verbatim (master). Preserve the
|
|
# configured level for an empty/unknown capability set; the provider stays
|
|
# the final authority. The known-bad CLAMP paths return a NON-empty set, so
|
|
# they are unaffected (covered by the openai-codex tests above).
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"high",
|
|
"some-unknown-model-xyz",
|
|
provider_id="some-custom-provider",
|
|
) == "high"
|
|
# #3505 default-deny refinement (maintainer 2026-07-11): 'max' is a supra-
|
|
# ceiling WebUI-only level, so on an UNRECOGNIZED provider it degrades to
|
|
# xhigh (a truly-unknown provider would 400 on max). All OTHER levels still
|
|
# preserve verbatim below.
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max",
|
|
"brand-new-model-2099",
|
|
provider_id="some-custom-provider",
|
|
) == "xhigh"
|
|
# 'none' / unset still pass through unchanged for unknown models.
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"none", "some-unknown-model-xyz", provider_id="custom"
|
|
) == "none"
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"", "some-unknown-model-xyz", provider_id="custom"
|
|
) == ""
|
|
|
|
|
|
def test_github_copilot_gpt5_supports_reasoning_effort_levels():
|
|
efforts = cfg.resolve_model_reasoning_efforts(
|
|
"gpt-5.5",
|
|
provider_id="github-copilot",
|
|
)
|
|
assert "medium" in efforts
|
|
assert "high" in efforts
|
|
|
|
|
|
def test_openrouter_anthropic_models_keep_reasoning_effort_levels():
|
|
efforts = cfg.resolve_model_reasoning_efforts(
|
|
"anthropic/claude-sonnet-4.5",
|
|
provider_id="openrouter",
|
|
)
|
|
assert "medium" in efforts
|
|
assert "high" in efforts
|
|
|
|
|
|
def test_non_reasoning_http_models_hide_reasoning_effort_levels():
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
"meta-llama/llama-3.1-8b-instruct",
|
|
provider_id="openrouter",
|
|
) == []
|
|
|
|
|
|
def test_provider_config_reasoning_efforts_return_filtered_deduped(monkeypatch):
|
|
original = cfg.cfg.get("providers")
|
|
monkeypatch.setitem(
|
|
cfg.cfg,
|
|
"providers",
|
|
{
|
|
"wandb": {
|
|
"reasoning_efforts": [
|
|
" none ",
|
|
"HIGH",
|
|
"bogus",
|
|
"high",
|
|
"xhigh",
|
|
]
|
|
}
|
|
},
|
|
)
|
|
try:
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
"zai-org/GLM-5.2",
|
|
provider_id="wandb",
|
|
) == ["none", "high", "xhigh"]
|
|
finally:
|
|
if original is None:
|
|
cfg.cfg.pop("providers", None)
|
|
else:
|
|
monkeypatch.setitem(cfg.cfg, "providers", original)
|
|
|
|
|
|
def test_provider_config_all_invalid_falls_through(monkeypatch):
|
|
original = cfg.cfg.get("providers")
|
|
monkeypatch.setitem(
|
|
cfg.cfg,
|
|
"providers",
|
|
{"wandb": {"reasoning_efforts": ["bogus", "typo"]}},
|
|
)
|
|
try:
|
|
result = cfg.resolve_model_reasoning_efforts(
|
|
"zai-org/GLM-5.2",
|
|
provider_id="wandb",
|
|
)
|
|
assert result != []
|
|
assert "bogus" not in result
|
|
assert "typo" not in result
|
|
finally:
|
|
if original is None:
|
|
cfg.cfg.pop("providers", None)
|
|
else:
|
|
monkeypatch.setitem(cfg.cfg, "providers", original)
|
|
|
|
|
|
def test_named_custom_provider_config_reasoning_efforts(monkeypatch):
|
|
original = cfg.cfg.get("custom_providers")
|
|
monkeypatch.setitem(
|
|
cfg.cfg,
|
|
"custom_providers",
|
|
[{"name": "llm-proxy", "reasoning_efforts": ["none", "high", "xhigh"]}],
|
|
)
|
|
try:
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
"some-model",
|
|
provider_id="custom:llm-proxy",
|
|
) == ["none", "high", "xhigh"]
|
|
finally:
|
|
if original is None:
|
|
cfg.cfg.pop("custom_providers", None)
|
|
else:
|
|
monkeypatch.setitem(cfg.cfg, "custom_providers", original)
|
|
|
|
|
|
def test_acp_guards_win_over_configured_reasoning_efforts(monkeypatch):
|
|
original = cfg.cfg.get("providers")
|
|
monkeypatch.setitem(
|
|
cfg.cfg,
|
|
"providers",
|
|
{"copilot-acp": {"reasoning_efforts": ["high"]}},
|
|
)
|
|
try:
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
"some-model",
|
|
provider_id="copilot-acp",
|
|
) == []
|
|
finally:
|
|
if original is None:
|
|
cfg.cfg.pop("providers", None)
|
|
else:
|
|
monkeypatch.setitem(cfg.cfg, "providers", original)
|
|
|
|
|
|
def test_nested_route_deny_wins_over_configured_reasoning_efforts(monkeypatch):
|
|
original = cfg.cfg.get("custom_providers")
|
|
monkeypatch.setitem(
|
|
cfg.cfg,
|
|
"custom_providers",
|
|
[{"name": "agg", "reasoning_efforts": ["low", "high"]}],
|
|
)
|
|
try:
|
|
for model in ("vertex/gemini-image-1.0", "vertex/gemini-embedding-001"):
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
model,
|
|
provider_id="custom:agg",
|
|
) == []
|
|
finally:
|
|
if original is None:
|
|
cfg.cfg.pop("custom_providers", None)
|
|
else:
|
|
monkeypatch.setitem(cfg.cfg, "custom_providers", original)
|
|
|
|
|
|
def test_nested_route_deny_wins_for_provider_qualified_hinted_model(monkeypatch):
|
|
# Regression for the deeper bypass: a provider-qualified hint like
|
|
# "@custom:agg:vertex/gemini-image-1.0" must strip BOTH the "@custom:"
|
|
# wrapper AND the named-provider slug "agg:" before the nested-route
|
|
# deny check runs. A naive first-colon split only strips "@custom:",
|
|
# leaving "agg:vertex/gemini-image-1.0" — which no longer starts with
|
|
# "vertex/gemini-" — so the deny is missed and the configured
|
|
# ["low", "high"] leaks through on an image/embedding route.
|
|
original = cfg.cfg.get("custom_providers")
|
|
monkeypatch.setitem(
|
|
cfg.cfg,
|
|
"custom_providers",
|
|
[{"name": "agg", "reasoning_efforts": ["low", "high"]}],
|
|
)
|
|
try:
|
|
for model in (
|
|
"@custom:agg:vertex/gemini-image-1.0",
|
|
"@custom:agg:vertex/gemini-embedding-001",
|
|
):
|
|
assert cfg.resolve_model_reasoning_efforts(
|
|
model,
|
|
provider_id="custom:agg",
|
|
) == []
|
|
finally:
|
|
if original is None:
|
|
cfg.cfg.pop("custom_providers", None)
|
|
else:
|
|
monkeypatch.setitem(cfg.cfg, "custom_providers", original)
|
|
|
|
|
|
def test_nested_route_deny_is_boundary_based_not_prefix_based():
|
|
# Structural regression test for the underlying invariant, independent
|
|
# of any particular wrapper/strip scheme: _nested_route_reasoning_denied
|
|
# must catch the vertex/gemini- or gemini_cli/gemini- route no matter
|
|
# how many opaque wrapper layers precede it in the raw string, as long
|
|
# as the route starts at a non-alphanumeric boundary. This was bypassed
|
|
# twice via different prefix-stripping edge cases (PR #5313) before the
|
|
# check itself was made boundary-based instead of prefix-based, so no
|
|
# future wrapper scheme can reintroduce the same class of bug.
|
|
denied_cases = [
|
|
"vertex/gemini-image-1.0",
|
|
"vertex/gemini-embedding-001",
|
|
"@custom:agg:vertex/gemini-image-1.0",
|
|
"agg:vertex/gemini-image-1.0", # the literal leftover fragment from the historical bug
|
|
"gemini_cli/gemini-imagine-2",
|
|
"outer:inner:vertex/gemini-image-1.0", # hypothetical deeper future nesting
|
|
"@custom:outer:@custom:inner:vertex/gemini-embedding-001",
|
|
]
|
|
for model in denied_cases:
|
|
assert cfg._nested_route_reasoning_denied(model) is True, model
|
|
|
|
allowed_cases = [
|
|
"vertex/gemini-2.5-pro",
|
|
"notvertex/gemini-image-1.0", # embedded in a larger token — must NOT match
|
|
"somegemini_cli/gemini-image-1", # same — embedded substring, not a boundary
|
|
"",
|
|
]
|
|
for model in allowed_cases:
|
|
assert cfg._nested_route_reasoning_denied(model) is False, model
|
|
|
|
|
|
def test_get_reasoning_status_includes_supported_efforts(monkeypatch):
|
|
monkeypatch.setattr(
|
|
cfg,
|
|
"resolve_model_reasoning_efforts",
|
|
lambda *a, **k: ["low", "medium", "high"],
|
|
)
|
|
status = cfg.get_reasoning_status(
|
|
model_id="gpt-5.5",
|
|
provider_id="openai-codex",
|
|
)
|
|
assert status["supported_efforts"] == ["low", "medium", "high"]
|
|
assert status["supports_reasoning_effort"] is True
|
|
|
|
|
|
def test_get_reasoning_status_for_reasoning_capable_model_has_no_max():
|
|
status = cfg.get_reasoning_status(
|
|
model_id="gpt-5.5",
|
|
provider_id="openai-codex",
|
|
)
|
|
assert status["supported_efforts"] == ["minimal", "low", "medium", "high", "xhigh"]
|
|
assert status["supports_reasoning_effort"] is True
|
|
assert "max" not in status["supported_efforts"]
|
|
|
|
|
|
def test_get_reasoning_status_coerces_stale_max_to_xhigh(monkeypatch):
|
|
"""A previously-saved `agent.reasoning_effort: max` (no longer a valid effort)
|
|
must be reported as the coerced `xhigh`, not the raw stale `max`, so the
|
|
boot/status/chip read paths agree with what streaming actually sends."""
|
|
monkeypatch.setattr(
|
|
cfg,
|
|
"_load_yaml_config_file",
|
|
lambda *a, **k: {"agent": {"reasoning_effort": "max"}},
|
|
)
|
|
status = cfg.get_reasoning_status(
|
|
model_id="gpt-5.5",
|
|
provider_id="openai-codex",
|
|
)
|
|
assert status["reasoning_effort"] == "xhigh"
|
|
assert status["reasoning_effort"] != "max"
|
|
|
|
|
|
def test_max_effort_degrades_to_xhigh_for_gemini():
|
|
# Gemini's native ladder tops out below 'max'; its adapter would silently
|
|
# treat an unknown 'max' as medium. A stored/CLI 'max' must degrade to xhigh
|
|
# (the highest supported), not fall through to a worse level. (#4627 gate)
|
|
for model in ("gemini-3-pro", "gemini-3-flash"):
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id=model, provider_id="gemini"
|
|
) == "xhigh", f"{model} max must degrade to xhigh"
|
|
|
|
|
|
def test_max_effort_degrades_to_xhigh_for_pre_adaptive_anthropic():
|
|
# Pre-adaptive Claude (3.7 / 4.0-4.5) uses manual thinking whose budget table
|
|
# lacks 'max' and falls back to 8k; 'max' must degrade to xhigh instead. (#4627 gate)
|
|
for model in (
|
|
"claude-3-7-sonnet", "claude-sonnet-4-5", "claude-haiku-4-5",
|
|
# date-stamped legacy IDs the Anthropic adapter uses
|
|
"claude-3-opus-20240229", "claude-3-5-sonnet-20241022",
|
|
"claude-sonnet-4-20250514", "claude-opus-4-20250514",
|
|
):
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id=model, provider_id="anthropic"
|
|
) == "xhigh", f"{model} max must degrade to xhigh"
|
|
|
|
|
|
def test_max_effort_preserved_for_adaptive_anthropic_and_deepseek():
|
|
# Adaptive Claude (4.6+) and DeepSeek genuinely support 'max' — it must NOT degrade.
|
|
for model in ("claude-opus-4.6", "claude-sonnet-4.6", "claude-opus-4.7", "claude-opus-latest"):
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id=model, provider_id="anthropic"
|
|
) == "max", f"{model} must preserve max"
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id="deepseek-reasoner", provider_id="deepseek"
|
|
) == "max"
|
|
|
|
|
|
def test_max_degrades_across_all_openai_family_lanes():
|
|
# 'max' is WebUI-only; direct OpenAI, openai-api, and Azure Foundry GPT-5 all
|
|
# cap at xhigh (o-series at high), not just openai-codex. (#4627 re-gate)
|
|
for prov in ("openai", "openai-api", "azure-foundry", "openai-codex"):
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id="gpt-5.1", provider_id=prov
|
|
) == "xhigh", f"gpt-5 on {prov} must degrade max->xhigh"
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id="o3", provider_id=prov
|
|
) == "high", f"o-series on {prov} must degrade max->high"
|
|
|
|
|
|
def test_max_degrades_for_azure_bedrock_hosted_legacy_claude():
|
|
# Legacy Claude via Azure Foundry / Bedrock is still pre-adaptive; the ceiling
|
|
# follows the model, not just the provider name. (#4627 re-gate)
|
|
for prov in ("azure-foundry", "bedrock"):
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id="claude-sonnet-4-20250514", provider_id=prov
|
|
) == "xhigh", f"legacy Claude on {prov} must degrade max->xhigh"
|
|
# adaptive Claude via azure preserves max
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id="claude-opus-4.6", provider_id="azure-foundry"
|
|
) == "max"
|
|
|
|
|
|
def test_max_degrades_on_unknown_provider_but_other_levels_preserved():
|
|
# #3505 default-deny refinement (maintainer call 2026-07-11): 'max' is above
|
|
# the universal ceiling, so an unknown/custom provider (empty capability list)
|
|
# must degrade 'max'->'xhigh' rather than send an unsupported level — while all
|
|
# other levels keep the conservative preserve-verbatim behavior.
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
"max", model_id="some-unknown-model", provider_id="customprovider"
|
|
) == "xhigh"
|
|
# other levels still preserved verbatim for an unknown provider
|
|
for eff in ("minimal", "low", "medium", "high", "xhigh"):
|
|
assert cfg.coerce_reasoning_effort_for_model(
|
|
eff, model_id="some-unknown-model", provider_id="customprovider"
|
|
) == eff, f"{eff} must be preserved verbatim on unknown provider (#3505)"
|
|
|
|
|
|
def test_max_only_offered_in_ui_when_actually_supported():
|
|
# The dropdown gates on resolve_model_reasoning_efforts(): 'max' appears ONLY
|
|
# for models whose supported list includes it (adaptive Claude, DeepSeek), and
|
|
# is absent for legacy/capped models and unknown providers.
|
|
assert "max" in cfg.resolve_model_reasoning_efforts("claude-opus-4.6", provider_id="anthropic")
|
|
assert "max" in cfg.resolve_model_reasoning_efforts("deepseek-reasoner", provider_id="deepseek")
|
|
assert "max" not in cfg.resolve_model_reasoning_efforts("claude-sonnet-4-5", provider_id="anthropic")
|
|
assert "max" not in cfg.resolve_model_reasoning_efforts("gpt-5.1", provider_id="openai")
|
|
assert "max" not in cfg.resolve_model_reasoning_efforts("gemini-3-pro", provider_id="gemini")
|
|
|
|
|
|
def test_datestamped_claude3_not_reasoning_capable_heuristic():
|
|
# A bare, date-stamped Claude 3.0 id must NOT be treated as reasoning-capable
|
|
# by the heuristic. The minor-version capture previously used `(\d+)`, which
|
|
# swallowed the 8-digit date stamp ("...-20240229") as the minor version so
|
|
# `major==3 and minor>=7` wrongly matched — surfacing reasoning-effort
|
|
# controls for models that don't support them. Claude 3.0/3.5 have no
|
|
# extended-thinking support; only 3.7+ (and 4.x) do.
|
|
for model in (
|
|
"claude-3-opus-20240229",
|
|
"claude-3-sonnet-20240229",
|
|
"claude-3-haiku-20240307",
|
|
"claude-3-opus",
|
|
"claude-3-5-sonnet-20241022",
|
|
):
|
|
assert cfg._candidate_supports_reasoning(model) is False, (
|
|
f"{model} must not be reasoning-capable (Claude 3.0/3.5 excluded)"
|
|
)
|
|
# 3.7+ and 4.x (including date-stamped builds) stay reasoning-capable.
|
|
for model in (
|
|
"claude-3-7-sonnet",
|
|
"claude-3-7-sonnet-20250219",
|
|
"claude-sonnet-4-5",
|
|
"claude-opus-4-20250514",
|
|
"claude-opus-4.6",
|
|
):
|
|
assert cfg._candidate_supports_reasoning(model) is True, (
|
|
f"{model} must remain reasoning-capable"
|
|
)
|
|
|