145410d642
Fixes ~5s GET /api/sessions on power users (2400+ sessions) — _enrich_sidebar_lineage_metadata probed state.db for every row's compression lineage. Caps to top-N (default 300, env HERMES_WEBUI_LINEAGE_TOP_N, 0=disable). Display-safe: both call sites pass an already pinned-first/newest-first sorted list, so sessions[:N] is exactly the paint-priority window. Fail-open preserved. Added regression test (RED on master, GREEN here). Code byte-faithful from PR head 016978578008. Co-authored-by: nesquena-hermes <agent@nesquena-hermes> Co-authored-by: maksym-mishchenko <maksym-mishchenko@users.noreply.github.com>
90 lines
3.6 KiB
Python
90 lines
3.6 KiB
Python
"""Regression tests for #4638 — cap sidebar lineage enrichment to the top-N sessions.
|
|
|
|
On power users with thousands of sessions, GET /api/sessions spent ~5s in
|
|
_enrich_sidebar_lineage_metadata probing state.db for EVERY row's compression
|
|
lineage. The sidebar paints pinned-first then newest-first, and the caller passes
|
|
an already-sorted list, so enriching only the top-N (default 300) most-recent rows
|
|
covers the visible window while bounding wall-clock. The cap is env-configurable
|
|
(HERMES_WEBUI_LINEAGE_TOP_N) and fails open.
|
|
|
|
These tests pin: (1) only the top-N ids are probed when the list exceeds the cap,
|
|
(2) the env override is honored, (3) a non-positive / unparseable cap disables the
|
|
cap (enrich all), (4) lists at/under the cap probe everything.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import api.models as models
|
|
|
|
|
|
def _capture_probed_ids(monkeypatch):
|
|
"""Patch read_session_lineage_metadata to record the id set it is asked for."""
|
|
seen = {}
|
|
|
|
def _fake_read(db_path, id_set):
|
|
seen["ids"] = set(id_set)
|
|
return {}
|
|
|
|
monkeypatch.setattr(models, "read_session_lineage_metadata", _fake_read)
|
|
monkeypatch.setattr(models, "_active_state_db_path", lambda: ":memory:")
|
|
return seen
|
|
|
|
|
|
def _sessions(n):
|
|
# Caller passes an already pinned-first/newest-first sorted list; index order
|
|
# therefore IS paint priority. id "s0" is the most-recent/visible-most.
|
|
return [{"session_id": f"s{i}"} for i in range(n)]
|
|
|
|
|
|
def test_caps_enrichment_to_top_n_default_300(monkeypatch):
|
|
seen = _capture_probed_ids(monkeypatch)
|
|
monkeypatch.delenv("HERMES_WEBUI_LINEAGE_TOP_N", raising=False)
|
|
models._enrich_sidebar_lineage_metadata(_sessions(1000))
|
|
assert seen["ids"] == {f"s{i}" for i in range(300)}, (
|
|
"Default cap must probe exactly the top-300 (paint-priority) sessions"
|
|
)
|
|
|
|
|
|
def test_env_override_changes_cap(monkeypatch):
|
|
seen = _capture_probed_ids(monkeypatch)
|
|
monkeypatch.setenv("HERMES_WEBUI_LINEAGE_TOP_N", "50")
|
|
models._enrich_sidebar_lineage_metadata(_sessions(1000))
|
|
assert seen["ids"] == {f"s{i}" for i in range(50)}, (
|
|
"HERMES_WEBUI_LINEAGE_TOP_N must bound the probed set"
|
|
)
|
|
|
|
|
|
def test_non_positive_cap_disables_capping(monkeypatch):
|
|
seen = _capture_probed_ids(monkeypatch)
|
|
monkeypatch.setenv("HERMES_WEBUI_LINEAGE_TOP_N", "0")
|
|
models._enrich_sidebar_lineage_metadata(_sessions(500))
|
|
assert len(seen["ids"]) == 500, "cap<=0 must enrich all sessions (cap disabled)"
|
|
|
|
|
|
def test_unparseable_cap_falls_back_to_default(monkeypatch):
|
|
seen = _capture_probed_ids(monkeypatch)
|
|
monkeypatch.setenv("HERMES_WEBUI_LINEAGE_TOP_N", "not-a-number")
|
|
models._enrich_sidebar_lineage_metadata(_sessions(1000))
|
|
assert seen["ids"] == {f"s{i}" for i in range(300)}, (
|
|
"An unparseable cap must fall back to the default 300, not crash"
|
|
)
|
|
|
|
|
|
def test_list_under_cap_probes_everything(monkeypatch):
|
|
seen = _capture_probed_ids(monkeypatch)
|
|
monkeypatch.delenv("HERMES_WEBUI_LINEAGE_TOP_N", raising=False)
|
|
models._enrich_sidebar_lineage_metadata(_sessions(120))
|
|
assert seen["ids"] == {f"s{i}" for i in range(120)}, (
|
|
"A list at/under the cap must enrich every session"
|
|
)
|
|
|
|
|
|
def test_enrichment_failure_is_swallowed(monkeypatch):
|
|
"""Lineage enrichment must fail open — a DB error never breaks /api/sessions."""
|
|
def _boom(db_path, id_set):
|
|
raise RuntimeError("db down")
|
|
|
|
monkeypatch.setattr(models, "read_session_lineage_metadata", _boom)
|
|
monkeypatch.setattr(models, "_active_state_db_path", lambda: ":memory:")
|
|
# Must not raise.
|
|
models._enrich_sidebar_lineage_metadata(_sessions(10))
|