carlotestor
fbb0843acf
Each approval/clarify fallback poller captures its own interval handle; a 409 (or finally) from a request issued by a replaced poller no longer stops or clears the in-flight guard of the poller that superseded it.
45 lines
2.0 KiB
Python
45 lines
2.0 KiB
Python
"""Static regressions for frontend passive polling hardening."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
SESSIONS_JS = ROOT / "static" / "sessions.js"
|
|
MESSAGES_JS = ROOT / "static" / "messages.js"
|
|
|
|
|
|
def _source(path: Path) -> str:
|
|
return path.read_text(encoding="utf-8")
|
|
|
|
|
|
def test_session_list_refreshes_are_coalesced_while_in_flight():
|
|
src = _source(SESSIONS_JS)
|
|
assert "let _renderSessionListInFlight = null" in src
|
|
assert "let _renderSessionListQueuedRequest = null" in src
|
|
assert "async function _runRenderSessionListRefresh" in src
|
|
assert "async function _drainRenderSessionListQueue" in src
|
|
assert "const request={opts:opts||{},gen:++_renderSessionListGen}" in src
|
|
assert "if(_renderSessionListInFlight)" in src
|
|
assert "_renderSessionListQueuedRequest={" in src
|
|
assert "opts:_mergeRenderSessionListOptions" in src
|
|
assert "if (_gen !== _renderSessionListGen) return" in src
|
|
assert "const sessionRequestOpts={" in src
|
|
assert "api('/api/sessions' + sessionListQS,sessionRequestOpts)" in src
|
|
assert "api('/api/projects' + projectQS,{timeoutToast:false})" in src
|
|
|
|
|
|
def test_approval_and_clarify_fallback_polls_do_not_overlap():
|
|
src = _source(MESSAGES_JS)
|
|
assert "let _approvalFallbackPollInFlight = false" in src
|
|
assert "if (_approvalFallbackPollInFlight) return" in src
|
|
assert "_approvalFallbackPollInFlight = true" in src
|
|
assert "finally { if (_approvalPollTimer === pollTimer) _approvalFallbackPollInFlight = false; }" in src
|
|
assert "_approvalFallbackPollInFlight = false;\n _approvalPollingSessionId = null;" in src
|
|
|
|
assert "let _clarifyFallbackPollInFlight = false" in src
|
|
assert "if (_clarifyFallbackPollInFlight) return" in src
|
|
assert "_clarifyFallbackPollInFlight = true" in src
|
|
assert "finally {\n if (_clarifyFallbackTimer === pollTimer) _clarifyFallbackPollInFlight = false;\n }" in src
|
|
assert "_clarifyFallbackPollInFlight = false;\n _clarifyPollingSessionId = null;" in src
|