fix(session): address Copilot round-2 review — correct stale comment and drop unused fixture arg

Two non-functional cleanups from the second Copilot pass:

1. The inline comment in `test_error_marker_no_preserved_as_draft`
   said the legacy "user message above was preserved" wording was used
   for the post-retry-give-up case.  The actual implementation demotes
   give-up markers to a different neutral wording ("Partial output may
   have been lost.").  Comment rewritten to match the contract.

2. The regression test `test_lost_response_recovered_on_second_read`
   declared a `monkeypatch` parameter it never used.  Dropped.
This commit is contained in:
Isla Liu committed 2026-05-20 13:08:08 +08:00
1 parent 9870e8f111
commit 1957785332
2 files changed
+4 -3

No files matched your search

@@ -100,7 +100,7 @@ def _make_dead_stream_session(
# ── The regression test ────────────────────────────────────────────────────
def test_lost_response_recovered_on_second_read(hermes_home, monkeypatch):
def test_lost_response_recovered_on_second_read(hermes_home):
sid = "9f14583f0e4e4444aaaa111122223333"
stream_id = "7c8b4108d52b4aba9af362d3a54f47ac"
+3 -2
View File
@@ -314,9 +314,10 @@ class TestDraftRecovery:
assert "Response interrupted" in content
assert "WebUI process restarted" in content
# The marker now arms the lazy-retry hook when a stream id is known
# (Recovering the partial output... reload to retry). The legacy
# ("Recovering the partial output… reload to retry."). The legacy
# "user message above was preserved" wording is reserved for the
# no-stream-id and post-retry-give-up cases.
# no-stream-id repair case; the post-retry-give-up case demotes to
# the neutral "Partial output may have been lost." wording instead.
assert (
"user message above was preserved" in content
or "Recovering the partial output" in content